Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alt text to saved payment method for accessibility #21090

Merged
merged 2 commits into from
Feb 13, 2019
Merged

Add alt text to saved payment method for accessibility #21090

merged 2 commits into from
Feb 13, 2019
+17 −7

Conversation

pmclain
Copy link
Contributor

@pmclain pmclain commented Feb 8, 2019 •
edited
Loading

Description (*)

Adds alt attribute value describing the credit card type or stored payment methods during checkout.

Fixed Issues (if relevant)

  1. No accessible label for vault-saved credit card type #21089: No accessible label for vault-saved credit card type

Manual testing scenarios (*)

  1. Save credit card using a Vault-enabled payment method, such as Braintree.
  2. Go to payment step on checkout.
  3. Inspect stored card logo for corresponding alt text.

screen shot 2019-02-08 at 6 22 47 pm

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @pmclain. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-4192 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team mentioned this pull request Feb 13, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit db4c00c into magento:2.3-develop Feb 13, 2019
@ghost
Copy link

ghost commented Feb 13, 2019

Hi @pmclain, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Feb 13, 2019
@sidolov
ENGCOM-4192: Add alt text to saved payment method for accessibility #…
3ca44d2 
…21090
@sidolov sidolov added this to the Release: 2.3.2 milestone Feb 13, 2019
@amol2jcommerce amol2jcommerce mentioned this pull request Feb 13, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidolov sidolov sidolov approved these changes

Assignees

@sidolov sidolov

Labels
Area: Frontend Award: bug fix Component: Payment Component: Vault Partner: Something Digital partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
4 participants
@pmclain @magento-engcom-team @sidolov @nmalevanec